Nailgun ssl cert verification #12813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
trigger: test-robottelo |
|
"trigger": "test-robottelo" |
jyejare
approved these changes
Oct 5, 2023
|
trigger: test-robottelo |
jyejare
added
CherryPick
|
@jyejare We need to add the same in the CI PR before merging this, otherwise regression would have an impact |
|
@omkarkhatavkar Not required, The validator should handle it and return |
|
@omkarkhatavkar Opened CI MR 1134 ! |
jyejare
approved these changes
Oct 9, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
* Add config option to verify nailgun requests against ssl cert * Use ssl verification for all instances of ServerConfig * Use dynaconf validator --------- Co-authored-by: dosas <[email protected]> (cherry picked from commit 0ddb4b7)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
* Add config option to verify nailgun requests against ssl cert * Use ssl verification for all instances of ServerConfig * Use dynaconf validator --------- Co-authored-by: dosas <[email protected]> (cherry picked from commit 0ddb4b7)
This was referenced Oct 9, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
* Add config option to verify nailgun requests against ssl cert * Use ssl verification for all instances of ServerConfig * Use dynaconf validator --------- Co-authored-by: dosas <[email protected]> (cherry picked from commit 0ddb4b7)
jyejare
pushed a commit
that referenced
this pull request
Oct 9, 2023
Nailgun ssl cert verification (#12813) * Add config option to verify nailgun requests against ssl cert * Use ssl verification for all instances of ServerConfig * Use dynaconf validator --------- Co-authored-by: dosas <[email protected]> (cherry picked from commit 0ddb4b7) Co-authored-by: dosas <[email protected]>
jyejare
pushed a commit
that referenced
this pull request
Oct 9, 2023
Nailgun ssl cert verification (#12813) * Add config option to verify nailgun requests against ssl cert * Use ssl verification for all instances of ServerConfig * Use dynaconf validator --------- Co-authored-by: dosas <[email protected]> (cherry picked from commit 0ddb4b7) Co-authored-by: dosas <[email protected]>
jyejare
pushed a commit
that referenced
this pull request
Oct 9, 2023
Nailgun ssl cert verification (#12813) * Add config option to verify nailgun requests against ssl cert * Use ssl verification for all instances of ServerConfig * Use dynaconf validator --------- Co-authored-by: dosas <[email protected]> (cherry picked from commit 0ddb4b7) Co-authored-by: dosas <[email protected]>
ColeHiggins2
pushed a commit
to ColeHiggins2/robottelo
that referenced
this pull request
Oct 9, 2023
* Add config option to verify nailgun requests against ssl cert * Use ssl verification for all instances of ServerConfig * Use dynaconf validator --------- Co-authored-by: dosas <[email protected]>
damoore044
pushed a commit
to damoore044/robottelo
that referenced
this pull request
Oct 10, 2023
* Add config option to verify nailgun requests against ssl cert * Use ssl verification for all instances of ServerConfig * Use dynaconf validator --------- Co-authored-by: dosas <[email protected]>
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
* Add config option to verify nailgun requests against ssl cert * Use ssl verification for all instances of ServerConfig * Use dynaconf validator --------- Co-authored-by: dosas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to overwrite the
verifysettings of nailgun's ServerConfigAccording to the setttings given by requests
Backwards compatibility is kept by defaulting to
Falseif the new settings option is not available.